Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SourceKitten and Yams #3319

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Update SourceKitten and Yams #3319

merged 1 commit into from
Aug 25, 2020

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Aug 25, 2020

Addresses #3300

@SwiftLintBot
Copy link

2 Warnings
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 1.83s vs 1.82s on master (0% slower)
📖 Linting Alamofire with this PR took 2.69s vs 2.68s on master (0% slower)
📖 Linting Firefox with this PR took 9.07s vs 9.12s on master (0% faster)
📖 Linting Kickstarter with this PR took 14.67s vs 14.68s on master (0% faster)
📖 Linting Moya with this PR took 1.36s vs 1.34s on master (1% slower)
📖 Linting Nimble with this PR took 1.37s vs 1.37s on master (0% slower)
📖 Linting Quick with this PR took 0.65s vs 0.66s on master (1% faster)
📖 Linting Realm with this PR took 2.67s vs 2.69s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.03s vs 1.06s on master (2% faster)
📖 Linting Sourcery with this PR took 7.08s vs 7.15s on master (0% faster)
📖 Linting Swift with this PR took 10.71s vs 10.78s on master (0% faster)
📖 Linting WordPress with this PR took 16.77s vs 16.74s on master (0% slower)

Here's an example of your CHANGELOG entry:

* Update SourceKitten and Yams.  
  [jpsim](https://github.com/jpsim)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2020

Codecov Report

Merging #3319 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3319   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files         416      416           
  Lines       20357    20357           
=======================================
  Hits        18437    18437           
  Misses       1920     1920           
Impacted Files Coverage Δ
...iftLintFramework/Extensions/String+SwiftLint.swift 94.54% <0.00%> (-1.82%) ⬇️
...ftLintFramework/Rules/Lint/PrivateOutletRule.swift 100.00% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e677737...81e8501. Read the comment docs.

@jpsim jpsim marked this pull request as ready for review August 25, 2020 02:52
@jpsim jpsim merged commit ff0e9f4 into master Aug 25, 2020
@jpsim jpsim deleted the update-sourcekitten-and-yams branch August 25, 2020 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants