Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed .swift-version with Swift 5.1 #3298

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Conversation

cfiken
Copy link
Contributor

@cfiken cfiken commented Aug 13, 2020

WIP: it may need to fix some tests. CI will be passed by merging #3299. ✅
Issue: #3297

@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2020

Codecov Report

Merging #3298 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3298      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.01%     
==========================================
  Files         416      416              
  Lines       20349    20349              
==========================================
- Hits        18435    18434       -1     
- Misses       1914     1915       +1     
Impacted Files Coverage Δ
...ftLintFramework/Rules/Lint/PrivateOutletRule.swift 96.15% <0.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8ad1d...776b7d7. Read the comment docs.

@jpsim
Copy link
Collaborator

jpsim commented Aug 13, 2020

Thanks!

@jpsim jpsim merged commit af2837e into realm:master Aug 13, 2020
@SwiftLintBot
Copy link

1 Error
🚫 Please rebase to get rid of the merge commits in this PR

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants