Add IBInspectableInExtensionRule #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
keith
force-pushed
the
ks/ibinspectable-extension
branch
from
b0c3e3b to
ee484f7
Compare
marcelofabri
reviewed
Aug 4, 2020
marcelofabri
approved these changes
Aug 4, 2020
This rule validates that there are no `@IBInspectable` variables in
`extension`s. The reason for this is that Interface Builder doesn't take
into account what code is actually included in your target to determine
if an inspectable should be valid. So in this case:
```swift
// Module A
extension UIView {
@IBInspectable public var foo: String? {
// do something
}
}
```
```swift
// Module B
// Uses `foo` in IB
```
If module B does not depend on module A interface builder will still
show the `foo` IBInspectable, but it will fail at runtime.
keith
force-pushed
the
ks/ibinspectable-extension
branch
from
449ec31 to
d7bb210
Compare
keith
force-pushed
the
ks/ibinspectable-extension
branch
from
d7bb210 to
713921f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule validates that there are no
@IBInspectablevariables inextensions. The reason for this is that Interface Builder doesn't takeinto account what code is actually included in your target to determine
if an inspectable should be valid. So in this case:
If module B does not depend on module A interface builder will still
show the
fooIBInspectable, but it will fail at runtime.