Add optional_enum_case_matching rule #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelofabri
force-pushed
the
marcelo/optional_enum_case_matching
branch
from
0369948 to
619439a
Compare
marcelofabri
force-pushed
the
marcelo/optional_enum_case_matching
branch
from
619439a to
8f128aa
Compare
marcelofabri
force-pushed
the
marcelo/optional_enum_case_matching
branch
from
8f128aa to
1309b8a
Compare
jpsim
reviewed
Jan 3, 2020
| public func violationRanges(in file: SwiftLintFile, | ||
| kind: StatementKind, | ||
| dictionary: SourceKittenDictionary) -> [NSRange] { | ||
| guard SwiftVersion.current >= type(of: self).description.minSwiftVersion, kind == .case else { |
There was a problem hiding this comment.
Nit: could've put the cheaper check before the more expensive check
|
💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made it opt-in because this introduces breaking changes (if violations are fixed) for projects that support compiling with earlier Swift versions - e.g. SwiftLint itself.