Update SourceKitten to 0.26.0 #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of your CHANGELOG entry: * Update SourceKitten to 0.26.0.
[marcelofabri](https://github.com/marcelofabri)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
jpsim
reviewed
Oct 21, 2019
| @@ -195,15 +195,15 @@ def build(branch) | |||
| perform("git fetch && git worktree add --detach #{dir} #{target}") | |||
| end | |||
|
|
|||
| Dir.chdir(dir) do | |||
There was a problem hiding this comment.
Why was this moved? This will slow down OSSCheck by preventing incremental builds.
There was a problem hiding this comment.
I was getting build failures all the time IIRC
There was a problem hiding this comment.
unfortunately CI has deleted the build, but you can see that OSSCheck had failed before 956ea6f: https://github.com/realm/SwiftLint/runs/251739677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2874?
Also should fix the CI failures on the
pod lib lint.