Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in function_default_parameter_at_end #2795

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2788

@SwiftLintBot
Copy link

13 Messages
📖 Linting Aerial with this PR took 2.77s vs 2.75s on master (0% slower)
📖 Linting Alamofire with this PR took 5.31s vs 5.28s on master (0% slower)
📖 Linting Firefox with this PR took 13.78s vs 13.73s on master (0% slower)
📖 Linting Kickstarter with this PR took 24.08s vs 24.12s on master (0% faster)
📖 Linting Moya with this PR took 2.73s vs 2.59s on master (5% slower)
📖 Linting Nimble with this PR took 2.24s vs 2.23s on master (0% slower)
📖 Linting Quick with this PR took 0.81s vs 0.86s on master (5% faster)
📖 Linting Realm with this PR took 3.94s vs 3.95s on master (0% faster)
📖 Linting SourceKitten with this PR took 1.5s vs 1.51s on master (0% faster)
📖 Linting Sourcery with this PR took 4.82s vs 4.82s on master (0% slower)
📖 Linting Swift with this PR took 37.27s vs 44.28s on master (15% faster)
📖 Linting WordPress with this PR took 30.46s vs 35.53s on master (14% faster)
📖 This PR fixed a violation in Swift: /Users/vsts/agent/2.153.2/work/1/s/osscheck/Swift/stdlib/public/Darwin/XCTest/XCTest.swift:651:8: warning: Function Default Parameter at End Violation: Prefer to locate parameters with defaults toward the end of the parameter list. (function_default_parameter_at_end)

Generated by 🚫 Danger

@marcelofabri marcelofabri merged commit b07c888 into master Jul 5, 2019
@marcelofabri marcelofabri deleted the mf-bugfix-2788 branch July 5, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

function_default_parameter_at_end false positive
2 participants