Add new indentation_width rule #2765

fredpi · 2019-05-21T07:41:01Z

It's been a while since #227 has last been discussed and it seems that an advanced indentation rule is somehow also pending some clarification on Xcode's side. However, since this issue has been open for such a long time, I thought about adding a basic additive indentation rule that only does the following things:

Check whether the next line is on the same level as the previous line or one tab or n spaces indented (where n can be configured via indentation_width) or unindented keeping the grid.
Check whether the first line is not indented.
Check whether spaces and tabs aren't mixed up in one line's indentation.

This PR implements such a basic rule. I tested it with a large project we have in our company and found out that it matches the indentation style we already pursued before:

let testStruct = TestStruct(
    name: "Test",
    indentation: "Cool"
)

However, this rule won't be compatible with other indentation styles like the one Xcode does by default and that is enforced by the vertical_parameter_alignment_on_call opt-in-rule:

let testStruct = TestStruct(name: "Test",
                            indentation: "Cool")

That's why this is an opt-in rule. As such, it won't do harm to those following another indentation style, yet enable built-in indentation linting for those who follow this basic additive pattern. Previously, we had implemented such a rule using multiple regexes that checked for indentation but didn't always work properly, so having this built-in is definitely a plus.

I want to mention that, according to this rule, unindentation can not only be done by one step (~ indentation_width spaces), but also by multiples of one step. This is to allow for the following indentation which I consider valid:

if
    let myLet = someBool ?
        myLet1 :
        myLet2
{
    // Do something with myLet
}

SwiftLintBot · 2019-05-21T08:17:04Z

	56723 Warnings
⚠️	Big PR
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/App/AppDelegate.swift:57:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/PrefsInfo.swift:76:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/PrefsInfo.swift:85:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/PrefsInfo.swift:94:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/PrefsInfo.swift:103:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:57:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:60:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/AssetLoaderDelegate.swift:82:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/AerialVideo.swift:153:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoManager.swift:190:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:110:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:213:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoLoader.swift:227:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:13:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:16:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:84:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:123:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:153:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:287:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoDownload.swift:301:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Hardware/DisplayDetection.swift:29:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Hardware/DisplayDetection.swift:108:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Hardware/DisplayDetection.swift:150:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Hardware/DisplayDetection.swift:169:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Hardware/DisplayDetection.swift:178:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/Preferences.swift:42:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/Preferences.swift:66:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/Preferences.swift:187:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/Preferences.swift:214:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/Preferences.swift:839:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Prefs/Preferences.swift:850:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:34:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:57:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:94:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:97:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:243:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:246:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Cache/VideoCache.swift:418:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Time/TimeManagement.swift:150:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Time/TimeManagement.swift:158:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Downloads/DownloadManager.swift:66:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/Downloads/DownloadManager.swift:78:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Time.swift:232:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:39:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:107:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:141:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:453:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:458:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:730:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:780:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Models/ManifestLoader.swift:836:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView+Player.swift:46:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView+Player.swift:71:1: warning: Indentation Width Violation: Code should be unindented by multiples of one tab or multiples of 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/ClockLayer.swift:39:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/CustomVideoController.swift:186:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/CustomVideoController.swift:441:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/CustomVideoController.swift:450:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PreferencesWindowController.swift:344:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoTableSource.swift:142:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoTableSource.swift:143:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/BatteryLayer.swift:39:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/MessageLayer.swift:38:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:183:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:186:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:189:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:192:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:245:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:248:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:251:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/InfoCommonView.swift:254:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/LocationLayer.swift:35:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/LocationLayer.swift:120:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:95:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:223:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:227:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:231:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:235:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:240:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:244:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:249:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:276:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:292:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:296:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:347:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:363:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:370:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:381:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:390:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:396:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:409:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:475:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:540:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:575:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:582:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:596:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:610:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Controllers/PWC Tabs/PWC+Videos.swift:642:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/AnimationLayer.swift:129:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/AnimationLayer.swift:134:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/AnimationLayer.swift:140:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/Layers/AnimationLayer.swift:216:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/DisplayView.swift:112:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/DisplayView.swift:130:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/DisplayView.swift:181:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/PrefPanel/DisplayView.swift:189:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView.swift:330:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView.swift:429:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView.swift:433:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView.swift:437:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	This PR introduced a violation in Aerial: /usr/local/var/buildkite-agent/builds/coastalelectricgaserver-com-1/swiftlint/swiftlint/osscheck/Aerial/Aerial/Source/Views/AerialView.swift:441:1: warning: Indentation Width Violation: Code should be indented using one tab or 4 spaces. (indentation_width)
⚠️	Danger found 56723 violations with this PR. Due to GitHub's max issue comment size, the number shown has been truncated to 111.

	12 Messages
📖	Linting Aerial with this PR took 1.2s vs 1.17s on master (2% slower)
📖	Linting Alamofire with this PR took 2.19s vs 2.16s on master (1% slower)
📖	Linting Firefox with this PR took 9.0s vs 8.84s on master (1% slower)
📖	Linting Kickstarter with this PR took 14.69s vs 14.25s on master (3% slower)
📖	Linting Moya with this PR took 1.16s vs 1.17s on master (0% faster)
📖	Linting Nimble with this PR took 1.36s vs 1.37s on master (0% faster)
📖	Linting Quick with this PR took 0.54s vs 0.54s on master (0% slower)
📖	Linting Realm with this PR took 2.36s vs 2.31s on master (2% slower)
📖	Linting SourceKitten with this PR took 0.99s vs 0.98s on master (1% slower)
📖	Linting Sourcery with this PR took 6.74s vs 6.6s on master (2% slower)
📖	Linting Swift with this PR took 12.44s vs 12.01s on master (3% slower)
📖	Linting WordPress with this PR took 14.86s vs 14.63s on master (1% slower)

Generated by 🚫 Danger

fredpi · 2019-06-17T13:33:56Z

Any thoughts on this? ;)

fredpi · 2019-07-13T08:59:31Z

As I'm personally not that active in reviewing other people's PRs, I'm certainly not in the position to complain that, seemingly, nobody wants to review this.

However, I'd still like to see this merged at some point. Don't be scared by the 41903 Warnings message, it's because not all projects follow the indentation pattern this rule enforces.

fredpi · 2019-09-07T21:54:16Z

@jpsim Would you mind having a look here? ;)

fredpi · 2019-10-18T11:41:11Z

Anyone?

fredpi · 2019-12-17T15:43:44Z

Rebasing this every 3 weeks or so is getting frustrating...

If nobody has time to review this, maybe one could give me push access so that I can self-review and merge thereafter...
As this is just an opt-in-rule, it doesn't do any harm...

fredpi · 2020-01-03T20:24:49Z

@marcelofabri Would you mind having a look here?

jpsim · 2020-01-05T22:47:16Z

Rebasing this every 3 weeks or so is getting frustrating...

If nobody has time to review this, maybe one could give me push access so that I can self-review and merge thereafter...
As this is just an opt-in-rule, it doesn't do any harm...

Sorry for the lack of communication here @fredpi. I don't have a whole lot of time for OSS work lately 😞

I've given you commit access to the repo. In general, you should feel empowered to merge PRs to SwiftLint if other maintainers aren't being responsive.

jpsim

Great rule 💯

CHANGELOG.md

…ation_width rule

… one single issue

…ance mechanism

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 1a0a6e5 to b83fb1e Compare June 3, 2019 14:18

fredpi force-pushed the feature/indentation_width branch from b83fb1e to 4b4c03e Compare July 13, 2019 08:53

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 2407a14 to 4f9d607 Compare July 27, 2019 09:44

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 71dda8d to 5fe042e Compare September 7, 2019 20:36

fredpi force-pushed the feature/indentation_width branch from 953b526 to 9947575 Compare October 18, 2019 11:35

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 8e49e17 to 693aace Compare October 27, 2019 06:39

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 7a628f2 to 4ddd3c1 Compare November 14, 2019 10:20

fredpi mentioned this pull request Nov 14, 2019

Add child and parent config configuration features #2824

Closed

fredpi force-pushed the feature/indentation_width branch from 4ddd3c1 to 2287fc8 Compare November 16, 2019 16:20

fredpi force-pushed the feature/indentation_width branch from 2287fc8 to 5fc91e3 Compare November 27, 2019 22:42

sashkopotapov approved these changes Dec 17, 2019

View reviewed changes

fredpi force-pushed the feature/indentation_width branch from 5fc91e3 to 3cd0d15 Compare December 17, 2019 15:39

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 0031f23 to 3e36ca7 Compare January 3, 2020 20:23

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from 68a5652 to b849922 Compare January 4, 2020 11:25

jpsim approved these changes Jan 5, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

fredpi added 15 commits January 6, 2020 08:30

Add new indentation_width rule

8c245c7

Add configuration option whether to consider comment lines for indent…

3a8ad94

…ation_width rule

Introduce mechanism to avoid duplicate indentation_width warnings for…

1fbb39d

… one single issue

Restructure indentation_width tests

35cd789

Add extensive tests for indentation_rule; fix duplicate warning avoid…

0bed014

…ance mechanism

Fix changelog format

0d9ad48

Fix changelog format

74adc87

Keep linting even when seeing mixed indentation

bc6396d

Fix wrong spacesEquivalent implementation; simplify validate method

eb92e0b

Update LinuxMain.swift

5c08e33

Fix changelog

08a986d

Fix modifier order

98e870e

Drop unused import statement

385b6c6

Fix changelog

95947b4

Fix rebase issues

d283904

fredpi force-pushed the feature/indentation_width branch 2 times, most recently from cb44955 to 6b40558 Compare January 6, 2020 07:35

Fix changelog

c806942

fredpi force-pushed the feature/indentation_width branch from 6b40558 to c806942 Compare January 6, 2020 07:42

Fix bug with no-syntax-kind lines (e. g. "[")

3d0b568

fredpi mentioned this pull request Jan 6, 2020

Add rule for proper indentation with preconfigured number of spaces #227

Closed

fredpi merged commit 601ea39 into realm:master Jan 6, 2020

fredpi deleted the feature/indentation_width branch January 6, 2020 09:47

iliaskarim mentioned this pull request Jan 6, 2020

make: `Source/SwiftLintFramework/Models/MasterRuleList.swift' is up to date #3018

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new indentation_width rule #2765

Add new indentation_width rule #2765

fredpi commented May 21, 2019 •

edited

Loading

SwiftLintBot commented May 21, 2019 •

edited

Loading

fredpi commented Jun 17, 2019

fredpi commented Jul 13, 2019

fredpi commented Sep 7, 2019

fredpi commented Oct 18, 2019

fredpi commented Dec 17, 2019

fredpi commented Jan 3, 2020

jpsim commented Jan 5, 2020

jpsim left a comment

Add new indentation_width rule #2765

Add new indentation_width rule #2765

Conversation

fredpi commented May 21, 2019 • edited Loading

SwiftLintBot commented May 21, 2019 • edited Loading

fredpi commented Jun 17, 2019

fredpi commented Jul 13, 2019

fredpi commented Sep 7, 2019

fredpi commented Oct 18, 2019

fredpi commented Dec 17, 2019

fredpi commented Jan 3, 2020

jpsim commented Jan 5, 2020

jpsim left a comment

Choose a reason for hiding this comment

fredpi commented May 21, 2019 •

edited

Loading

SwiftLintBot commented May 21, 2019 •

edited

Loading