Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reduce to reduce:into for a bit faster running #2657

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

PaulTaykalo
Copy link
Collaborator

@PaulTaykalo PaulTaykalo commented Feb 21, 2019

Few more milliseconds by using reduce
image

@SwiftLintBot
Copy link

SwiftLintBot commented Feb 21, 2019

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 1.8s vs 1.88s on master (4% faster)
📖 Linting Alamofire with this PR took 3.95s vs 4.89s on master (19% faster)
📖 Linting Firefox with this PR took 12.49s vs 12.93s on master (3% faster)
📖 Linting Kickstarter with this PR took 19.65s vs 20.38s on master (3% faster)
📖 Linting Moya with this PR took 1.86s vs 1.91s on master (2% faster)
📖 Linting Nimble with this PR took 1.92s vs 1.85s on master (3% slower)
📖 Linting Quick with this PR took 0.63s vs 0.61s on master (3% slower)
📖 Linting Realm with this PR took 3.72s vs 3.41s on master (9% slower)
📖 Linting SourceKitten with this PR took 1.11s vs 1.11s on master (0% slower)
📖 Linting Sourcery with this PR took 4.1s vs 4.26s on master (3% faster)
📖 Linting Swift with this PR took 26.81s vs 26.74s on master (0% slower)
📖 Linting WordPress with this PR took 21.09s vs 21.06s on master (0% slower)

Here's an example of your CHANGELOG entry:

* Update reduce to reduce:into for a bit faster running.  
  [PaulTaykalo](https://github.com/PaulTaykalo)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jpsim jpsim merged commit 1b0ac66 into realm:master Feb 22, 2019
sjavora pushed a commit to sjavora/SwiftLint that referenced this pull request Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants