Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SourceKitten #2279

Merged
merged 4 commits into from
Jul 5, 2018
Merged

Update SourceKitten #2279

merged 4 commits into from
Jul 5, 2018

Conversation

norio-nomura
Copy link
Collaborator

This will fix #2273

@SwiftLintBot
Copy link

SwiftLintBot commented Jul 5, 2018

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.37s vs 0.39s on master (5% faster)
📖 Linting Alamofire with this PR took 3.33s vs 3.49s on master (4% faster)
📖 Linting Firefox with this PR took 13.13s vs 12.66s on master (3% slower)
📖 Linting Kickstarter with this PR took 20.72s vs 17.09s on master (21% slower)
📖 Linting Moya with this PR took 2.31s vs 1.89s on master (22% slower)
📖 Linting Nimble with this PR took 1.84s vs 1.56s on master (17% slower)
📖 Linting Quick with this PR took 0.57s vs 0.5s on master (13% slower)
📖 Linting Realm with this PR took 3.58s vs 3.17s on master (12% slower)
📖 Linting SourceKitten with this PR took 1.16s vs 0.98s on master (18% slower)
📖 Linting Sourcery with this PR took 5.08s vs 4.48s on master (13% slower)
📖 Linting Swift with this PR took 31.7s vs 27.81s on master (13% slower)
📖 Linting WordPress with this PR took 18.84s vs 15.31s on master (23% slower)

Here's an example of your CHANGELOG entry:

* Update SourceKitten.  
  [norio-nomura](https://github.com/norio-nomura)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented Jul 5, 2018

Codecov Report

Merging #2279 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2279      +/-   ##
==========================================
+ Coverage   92.11%   92.12%   +<.01%     
==========================================
  Files         286      286              
  Lines       14533    14533              
==========================================
+ Hits        13387    13388       +1     
+ Misses       1146     1145       -1
Impacted Files Coverage Δ
...iftLintFramework/Extensions/String+SwiftLint.swift 91.07% <0%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c8d5a4...3dcb072. Read the comment docs.

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I had done this but I actually never create a PR 😅

Thanks for doing this!

@norio-nomura
Copy link
Collaborator Author

🙂

@clayreimann
Copy link

Looks like this isn't released to cocoapods, any reason in particular?

@mzp mzp mentioned this pull request Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants