Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in redundant_set_access_control #2183

Merged
merged 1 commit into from
May 7, 2018
Merged

Fix false positive in redundant_set_access_control #2183

merged 1 commit into from
May 7, 2018

Conversation

marcelofabri
Copy link
Collaborator

Fixes #2182

Not adding a changelog entry because this rule hasn't been officially released it

@SwiftLintBot
Copy link

SwiftLintBot commented May 6, 2018

2 Warnings
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 0.39s vs 0.35s on master (11% slower)
📖 Linting Alamofire with this PR took 3.37s vs 3.05s on master (10% slower)
📖 Linting Firefox with this PR took 13.01s vs 11.22s on master (15% slower)
📖 Linting Kickstarter with this PR took 19.68s vs 16.12s on master (22% slower)
📖 Linting Moya with this PR took 2.07s vs 1.82s on master (13% slower)
📖 Linting Nimble with this PR took 1.82s vs 1.49s on master (22% slower)
📖 Linting Quick with this PR took 0.52s vs 0.49s on master (6% slower)
📖 Linting Realm with this PR took 3.56s vs 3.11s on master (14% slower)
📖 Linting SourceKitten with this PR took 1.08s vs 0.96s on master (12% slower)
📖 Linting Sourcery with this PR took 4.81s vs 4.32s on master (11% slower)
📖 Linting Swift with this PR took 27.87s vs 26.04s on master (7% slower)
📖 Linting WordPress with this PR took 14.73s vs 14.17s on master (3% slower)

Here's an example of your CHANGELOG entry:

* Fix false positive in redundant_set_access_control.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@codecov-io
Copy link

codecov-io commented May 6, 2018

Codecov Report

Merging #2183 into master will increase coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
+ Coverage      92%   92.01%   +<.01%     
==========================================
  Files         276      276              
  Lines       13830    13843      +13     
==========================================
+ Hits        12724    12737      +13     
  Misses       1106     1106
Impacted Files Coverage Δ
...ramework/Rules/RedundantSetAccessControlRule.swift 96.66% <92.3%> (-3.34%) ⬇️
Source/SwiftLintFramework/Models/Command.swift 98.7% <0%> (+1.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a340a2...dc93d1d. Read the comment docs.

@jpsim
Copy link
Collaborator

jpsim commented May 6, 2018

Is there a way to keep the violation on fileprivate/fileprivate?

@marcelofabri
Copy link
Collaborator Author

@jpsim I think I've found a way! Let's see if osscheck finds anything interesting.

@jpsim
Copy link
Collaborator

jpsim commented May 7, 2018

Smart! Well done! 👏

@jpsim jpsim merged commit fcaa675 into realm:master May 7, 2018
@marcelofabri marcelofabri deleted the bugfix-2182 branch May 7, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants