Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SwiftDeclarationAttributeKind instead of string constants #2152

Merged
merged 2 commits into from
Apr 25, 2018

Conversation

marcelofabri
Copy link
Collaborator

SwiftDeclarationAttributeKind was added in the latest release of SourceKitten 🎉

@SwiftLintBot
Copy link

SwiftLintBot commented Apr 13, 2018

2 Warnings
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
⚠️ This PR may need tests.
12 Messages
📖 Linting Aerial with this PR took 0.39s vs 0.36s on master (8% slower)
📖 Linting Alamofire with this PR took 3.38s vs 2.91s on master (16% slower)
📖 Linting Firefox with this PR took 13.19s vs 10.68s on master (23% slower)
📖 Linting Kickstarter with this PR took 18.76s vs 15.4s on master (21% slower)
📖 Linting Moya with this PR took 2.23s vs 1.77s on master (25% slower)
📖 Linting Nimble with this PR took 1.62s vs 1.43s on master (13% slower)
📖 Linting Quick with this PR took 0.51s vs 0.48s on master (6% slower)
📖 Linting Realm with this PR took 3.69s vs 2.96s on master (24% slower)
📖 Linting SourceKitten with this PR took 1.04s vs 0.9s on master (15% slower)
📖 Linting Sourcery with this PR took 4.76s vs 4.13s on master (15% slower)
📖 Linting Swift with this PR took 28.42s vs 24.11s on master (17% slower)
📖 Linting WordPress with this PR took 14.39s vs 13.47s on master (6% slower)

Here's an example of your CHANGELOG entry:

* Use SwiftDeclarationAttributeKind instead of string constants.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@jpsim
Copy link
Collaborator

jpsim commented Apr 22, 2018

Now that SourceKitten 0.20.0 is out, can we update this & merge?

@marcelofabri
Copy link
Collaborator Author

jpsim/SourceKitten#512 needs to be released as well

@jpsim
Copy link
Collaborator

jpsim commented Apr 22, 2018

OK, will do.

@jpsim
Copy link
Collaborator

jpsim commented Apr 23, 2018

@marcelofabri marcelofabri force-pushed the mf-SwiftDeclarationAttributeKind branch from a91c44b to e2b195a Compare April 25, 2018 05:24
@codecov-io
Copy link

Codecov Report

Merging #2152 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2152      +/-   ##
==========================================
- Coverage   91.84%   91.84%   -0.01%     
==========================================
  Files         269      269              
  Lines       13192    13190       -2     
==========================================
- Hits        12116    12114       -2     
  Misses       1076     1076
Impacted Files Coverage Δ
...ftLintFramework/Rules/ValidIBInspectableRule.swift 98.63% <100%> (-0.02%) ⬇️
.../SwiftLintFramework/Rules/IdentifierNameRule.swift 98.73% <100%> (ø) ⬆️
...mework/Rules/QuickDiscouragedPendingTestRule.swift 100% <100%> (ø) ⬆️
...ntFramework/Rules/FunctionParameterCountRule.swift 98.43% <100%> (ø) ⬆️
...e/SwiftLintFramework/Rules/PrivateActionRule.swift 100% <100%> (ø) ⬆️
...ce/SwiftLintFramework/Rules/WeakDelegateRule.swift 98.18% <100%> (ø) ⬆️
...SwiftLintFramework/Rules/ProhibitedSuperRule.swift 100% <100%> (ø) ⬆️
...intFramework/Extensions/Dictionary+SwiftLint.swift 87.83% <100%> (+0.16%) ⬆️
...ules/DiscardedNotificationCenterObserverRule.swift 100% <100%> (ø) ⬆️
...LintFramework/Rules/QuickDiscouragedCallRule.swift 100% <100%> (ø) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b7baf...8d90dc7. Read the comment docs.

@marcelofabri marcelofabri merged commit f61b1cf into master Apr 25, 2018
@marcelofabri marcelofabri deleted the mf-SwiftDeclarationAttributeKind branch April 25, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants