Improve ControlStatementRule for issues #187 and #189 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in condition and several bad cases appears
mmorier
changed the title
| return self[from..<from + length] | ||
| } | ||
|
|
||
| public func lastIndexOf(search: String) -> Int { |
There was a problem hiding this comment.
why not return -> Int?, returning nil instead of -1 when not found?
There was a problem hiding this comment.
Good point, dunno why I'm not use optional benefit for this function. I'll change it now.
|
I like what you're doing here! I just had a few minor comments that I'd like you to address. Could you also please add an entry to the CHANGELOG.md? Thanks! |
|
Thank you. I like coded on this tool:-) |
…on variable name
|
This is great. Thanks for the hard work, @mmorier. I've made you a SwiftLint contributor which should make it easier for you to contribute in the future 😄 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fix false positive for
ControlStatementRulethat we have notice in issue #189. To do that, I had to check condition's depth.I also fix issue #187 with this PR in remove closing curly bracket from regex.
I had some function in
String+Swiftlintto make easier substring and index search.