Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up issue template in "rule request" and "bug report" sections #1792

Merged
merged 5 commits into from
Aug 21, 2017

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Aug 21, 2017

No description provided.

@jpsim jpsim requested a review from marcelofabri August 21, 2017 17:34
(If this is a new rule request, please ignore everything below.)
If this is a bug report, please ignore this section.

If this is a new rule request, please ignore all sections below this one, label
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only collaborators can add labels

the community thinks about this.
2. Provide several examples of what _would_ and _wouldn't_ trigger violations.
3. Should the rule be configurable, if so what parameters should be configurable?
4. Should the rule be opt-in or enabled by default? Why?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe link to README where we explain reasons for a rule to be opt-in?

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this 👍

Just made two minor comments.

@jpsim
Copy link
Collaborator Author

jpsim commented Aug 21, 2017

Thanks for the suggestions!

@jpsim jpsim merged commit 4f7a098 into master Aug 21, 2017
@jpsim jpsim deleted the jp-refactor-issue-template branch August 21, 2017 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants