Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate implicit subscript get #1768

Closed
wants to merge 2 commits into from

Conversation

marcelofabri
Copy link
Collaborator

Fixes #898

This depends on swiftlang/swift#11258 (which is already available on latest development snapshots).

I don't know how should we proceed with this one. Should we merge right away? Or wait for that PR to be on an official release?

This also needs a CHANGELOG entry.

@SwiftLintBot
Copy link

SwiftLintBot commented Aug 11, 2017

1 Warning
⚠️ Please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
12 Messages
📖 Linting Aerial with this PR took 0.36s vs 0.34s on master (5% slower)
📖 Linting Alamofire with this PR took 2.39s vs 2.38s on master (0% slower)
📖 Linting Firefox with this PR took 9.97s vs 10.37s on master (3% faster)
📖 Linting Kickstarter with this PR took 14.89s vs 14.77s on master (0% slower)
📖 Linting Moya with this PR took 1.01s vs 1.01s on master (0% slower)
📖 Linting Nimble with this PR took 1.37s vs 1.37s on master (0% slower)
📖 Linting Quick with this PR took 0.44s vs 0.44s on master (0% slower)
📖 Linting Realm with this PR took 2.11s vs 2.09s on master (0% slower)
📖 Linting SourceKitten with this PR took 0.8s vs 0.78s on master (2% slower)
📖 Linting Sourcery with this PR took 3.57s vs 3.55s on master (0% slower)
📖 Linting Swift with this PR took 9.94s vs 10.02s on master (0% faster)
📖 Linting WordPress with this PR took 9.3s vs 9.31s on master (0% faster)

Here's an example of your CHANGELOG entry:

* Validate implicit subscript get.  
  [marcelofabri](https://github.com/marcelofabri)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

@jpsim
Copy link
Collaborator

jpsim commented Aug 21, 2017

Let's revisit when Swift 4.1 is out?

@marcelofabri
Copy link
Collaborator Author

In theory we could make it already available for people using preview toolchains, but I guess no one actually does that. I'll close it by now, but keep the branch alive.

@marcelofabri marcelofabri deleted the validate-implicit-subscript-get branch April 8, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants