Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies, mostly for SourceKitten 0.18 #1668

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

jpsim
Copy link
Collaborator

@jpsim jpsim commented Jul 12, 2017

Fixes #1577 but also bumps the requirements to build SwiftLint.

@SwiftLintBot
Copy link

2 Warnings
⚠️ This PR may need tests.
⚠️ This PR introduced a violation in WordPress: /WordPress/WordPressShareExtension/NSURLSessionConfiguration+Extensions.swift#L3: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
32 Messages
📖 Linting Aerial with this PR took 0.37s vs 0.33s on master (12% slower)
📖 Linting Alamofire with this PR took 2.41s vs 2.38s on master (1% slower)
📖 Linting Firefox with this PR took 10.79s vs 10.35s on master (4% slower)
📖 Linting Kickstarter with this PR took 6.02s vs 5.74s on master (4% slower)
📖 Linting Moya with this PR took 0.68s vs 0.65s on master (4% slower)
📖 Linting Nimble with this PR took 1.41s vs 1.34s on master (5% slower)
📖 Linting Quick with this PR took 0.48s vs 0.43s on master (11% slower)
📖 Linting Realm with this PR took 2.11s vs 2.07s on master (1% slower)
📖 Linting SourceKitten with this PR took 0.88s vs 0.86s on master (2% slower)
📖 Linting Sourcery with this PR took 2.92s vs 2.8s on master (4% slower)
📖 Linting Swift with this PR took 4.04s vs 3.87s on master (4% slower)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L12:5: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L49:17: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L139:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L140:9: warning: Explicit Type Interface Violation: Properties should have a type interface (explicit_type_interface)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L7:1: warning: Explicit Top Level ACL Violation: Top-level declarations should specify Access Control Level keywords explicitly. (explicit_top_level_acl)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L4: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L52: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 3. (vertical_whitespace)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L66: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 3. (vertical_whitespace)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L104: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 2. (vertical_whitespace)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L135: warning: Vertical Whitespace Violation: Limit vertical whitespace to a single empty line. Currently 3. (vertical_whitespace)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L41:17: warning: Implicitly Unwrapped Optional Violation: Implicitly unwrapped optionals should be avoided when possible. (implicitly_unwrapped_optional)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L45:17: warning: Implicitly Unwrapped Optional Violation: Implicitly unwrapped optionals should be avoided when possible. (implicitly_unwrapped_optional)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L20:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L32:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L41:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L45:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L49:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L107:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L129:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 This PR fixed a violation in WordPress: /WordPress/WordPressShareExtension/MediaView.swift#L138:5: warning: Strict fileprivate Violation: fileprivate should be avoided. (strict_fileprivate)
📖 Linting WordPress with this PR took 8.77s vs 8.39s on master (4% slower)

Generated by 🚫 Danger

@jpsim
Copy link
Collaborator Author

jpsim commented Jul 12, 2017

Something's broken with OSSCheck... Looking into it.

@codecov-io
Copy link

Codecov Report

Merging #1668 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1668      +/-   ##
==========================================
+ Coverage   87.34%   87.34%   +<.01%     
==========================================
  Files         201      201              
  Lines        9996     9998       +2     
==========================================
+ Hits         8731     8733       +2     
  Misses       1265     1265
Impacted Files Coverage Δ
...intFramework/Rules/ClosureEndIndentationRule.swift 97.59% <100%> (ø) ⬆️
...amework/Rules/VerticalParameterAlignmentRule.swift 100% <100%> (ø) ⬆️
...SwiftLintFramework/Rules/ForceUnwrappingRule.swift 96.25% <100%> (ø) ⬆️
.../SwiftLintFramework/Rules/ImplicitReturnRule.swift 100% <100%> (ø) ⬆️
...ork/Extensions/NSRegularExpression+SwiftLint.swift 100% <100%> (ø) ⬆️
...SwiftLintFramework/Rules/GenericTypeNameRule.swift 93.54% <100%> (ø) ⬆️
...intFramework/Rules/ReturnArrowWhitespaceRule.swift 68.33% <100%> (ø) ⬆️
Source/SwiftLintFramework/Rules/CommaRule.swift 95.38% <100%> (ø) ⬆️
...iftLintFramework/Rules/ShorthandOperatorRule.swift 84.37% <100%> (ø) ⬆️
...iftLintFramework/Rules/StatementPositionRule.swift 96.19% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 629b053...7acacf6. Read the comment docs.

Copy link
Collaborator

@marcelofabri marcelofabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@jpsim jpsim merged commit 893d667 into master Jul 12, 2017
@jpsim jpsim deleted the jp-update-dependencies branch July 12, 2017 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants