Adds support for excluded in custom rules

[nigelflack]

Adds support for excluded in custom rules to specify a regex for files to exclude.

[SwiftLintBot]

	22 Warnings
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressApi/WordPressComRestApi.swift#L90:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/SwipeAnimator.swift#L61:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/SwipeAnimator.swift#L105:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L15:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L115:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L224:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Home/TopSitesPanel.swift#L201:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Shared/Extensions/NSURLExtensions.swift#L395:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /SharedTests/NSURLExtensionsTests.swift#L73:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /SharedTests/NSURLExtensionsTests.swift#L121:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/Extensions/NSURL+Exporters.swift#L207:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L237:1: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/NUX/SigninHelpers.swift#L14:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Plans/PlanDetailViewController.swift#L179:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSearchSuggestionsViewController.swift#L94:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/ViewRelated/Views/BadgeLabel.swift#L43:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressApi/WordPressRSDParser.swift#L29:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L46:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L147:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L180:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L198:5: warning: Mark Violation: MARK comment should be in valid format. (mark)
⚠️	This PR introduced a violation in WordPress: /WordPress/Classes/Networking/NotificationSyncServiceRemote.swift#L110:1: warning: Mark Violation: MARK comment should be in valid format. (mark)

	44 Messages
📖	Linting WordPress with this PR took 12.46s vs 12.39s on master (0% slower)
📖	Linting Alamofire with this PR took 3.09s vs 3.1s on master (0% faster)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserTrayAnimators.swift#L237:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Browser/SwipeAnimator.swift#L61:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Browser/SwipeAnimator.swift#L105:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L1037:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Browser/BrowserViewController.swift#L1093:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L15:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L115:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Home/ActivityStreamPanel.swift#L224:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Home/TopSitesPanel.swift#L201:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Widgets/Menu/MenuView.swift#L252:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Client/Frontend/Widgets/Menu/MenuView.swift#L306:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /Shared/Extensions/NSURLExtensions.swift#L395:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /SharedTests/NSURLExtensionsTests.swift#L73:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /SharedTests/NSURLExtensionsTests.swift#L121:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /StoragePerfTests/StoragePerfTests.swift#L78:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Firefox: /StorageTests/TestSQLiteHistory.swift#L1445:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	Linting Firefox with this PR took 17.38s vs 17.22s on master (0% slower)
📖	Linting Kickstarter with this PR took 17.24s vs 17.2s on master (0% slower)
📖	Linting Moya with this PR took 0.41s vs 0.4s on master (2% slower)
📖	Linting Nimble with this PR took 1.78s vs 1.76s on master (1% slower)
📖	Linting Aerial with this PR took 0.42s vs 0.41s on master (2% slower)
📖	This PR fixed a violation in Realm: /RealmSwift/Tests/MigrationTests.swift#L46:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in Realm: /RealmSwift/Tests/MigrationTests.swift#L88:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	Linting Realm with this PR took 2.75s vs 2.72s on master (1% slower)
📖	Linting SourceKitten with this PR took 1.16s vs 1.16s on master (0% slower)
📖	Linting Sourcery with this PR took 3.01s vs 3.02s on master (0% faster)
📖	Linting Swift with this PR took 11.12s vs 11.11s on master (0% slower)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/Extensions/NSURL+Exporters.swift#L207:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/Networking/NotificationSyncServiceRemote.swift#L110:1: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/NUX/SigninHelpers.swift#L14:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Plans/PlanDetailViewController.swift#L179:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Post/AbstractPostListViewController.swift#L950:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderSearchSuggestionsViewController.swift#L94:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Views/BadgeLabel.swift#L43:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/Classes/ViewRelated/Reader/ReaderStreamViewController.swift#L1636:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/WordPressApi/WordPressRSDParser.swift#L29:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L46:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L147:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L180:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/WordPressApi/WordPressOrgXMLRPCApi.swift#L198:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	This PR fixed a violation in WordPress: /WordPress/WordPressApi/WordPressComRestApi.swift#L90:5: warning: Mark Violation: MARK comment should be in valid format. e.g. ‘// MARK: …’ or ‘// MARK: - …’ (mark)
📖	Linting Quick with this PR took 0.52s vs 0.52s on master (0% slower)

Generated by 🚫 danger

[codecov-io]

Codecov Report

Merging #1438 into master will increase coverage by 0.03%.
The diff coverage is 86.95%.

@@            Coverage Diff             @@
##           master    #1438      +/-   ##
==========================================
+ Coverage   81.13%   81.16%   +0.03%     
==========================================
  Files         180      180              
  Lines        9184     9213      +29     
==========================================
+ Hits         7451     7478      +27     
- Misses       1733     1735       +2

Impacted Files	Coverage Δ
.../Rules/RuleConfigurations/RegexConfiguration.swift	94.59% <100%> (+0.65%)	⬆️
Source/SwiftLintFramework/Rules/CustomRules.swift	96% <100%> (+0.54%)	⬆️
...sts/SwiftLintFrameworkTests/CustomRulesTests.swift	78.35% <75%> (+0.44%)	⬆️
...ork/Extensions/NSRegularExpression+SwiftLint.swift	100% <0%> (ø)	⬆️
Source/SwiftLintFramework/Rules/MarkRule.swift	100% <0%> (ø)	⬆️
...ftLintFramework/Reporters/CheckstyleReporter.swift	93.54% <0%> (+0.21%)	⬆️
...e/SwiftLintFramework/Reporters/EmojiReporter.swift	90.47% <0%> (+0.47%)	⬆️
Tests/SwiftLintFrameworkTests/ReporterTests.swift	84.44% <0%> (+0.72%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54042cb...cc179c5. Read the comment docs.

[marcelofabri]

Can you add some tests on CustomRulesTests.swift so we don't break this in the future?

[marcelofabri]

Maybe we need to rethink the name since this can be confused with #1408.

I've seen that you actually opened a ticket to discuss the potentially confusing names: #1353

[nigelflack]

Yes I'll look at adding some tests. Sorry... first github contribution :-)

And I've updated #1353 with some further thoughts.

[marcelofabri]

This looks good to me, but could you add some documentation about this on README?

[marcelofabri]

Thanks! 💯