Skip module import if cursor info is missing module info (#2746)

realm · May 6, 2019 · af72c06 · af72c06
1 parent ef50162
commit af72c06
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,10 @@
   return type is required.  
   [Marcelo Fabri](https://github.com/marcelofabri)
 
+* Skip module import if cursor info is missing module info.  
+  [alvarhansen](https://github.com/alvarhansen)
+  [#2746](https://github.com/realm/SwiftLint/issues/2746)
+
 ## 0.32.0: Wash-N-Fold-N-Reduce
 
 #### Breaking

diff --git a/Rules.md b/Rules.md
@@ -23574,6 +23574,11 @@ import Foundation
 class A {}
 ```
 
+```swift
+import UnknownModule
+func foo(error: Swift.Error) {}
+```
+
 </details>
 <details>
 <summary>Triggering Examples</summary>
@@ -23607,6 +23612,12 @@ dispatchMain()
 class A {}
 ```
 
+```swift
+↓import Foundation
+import UnknownModule
+func foo(error: Swift.Error) {}
+```
+
 </details>
 
 

diff --git a/Source/SwiftLintFramework/Rules/Lint/UnusedImportRule.swift b/Source/SwiftLintFramework/Rules/Lint/UnusedImportRule.swift
@@ -24,6 +24,10 @@ public struct UnusedImportRule: CorrectableRule, ConfigurationProviderRule, Anal
             import Foundation
             @objc
             class A {}
+            """,
+            """
+            import UnknownModule
+            func foo(error: Swift.Error) {}
             """
         ],
         triggeringExamples: [
@@ -51,6 +55,11 @@ public struct UnusedImportRule: CorrectableRule, ConfigurationProviderRule, Anal
             ↓import Foundation
             // @objc
             class A {}
+            """,
+            """
+            ↓import Foundation
+            import UnknownModule
+            func foo(error: Swift.Error) {}
             """
         ],
         corrections: [
@@ -181,9 +190,9 @@ private extension File {
                     imports.insert(importedModule)
                     nextIsModuleImport = false
                     continue
+                } else {
+                    nextIsModuleImport = false
                 }
-            } else {
-                nextIsModuleImport = false
             }
 
             if let usr = cursorInfo["key.modulename"] as? String {