Skip to content

Fix delete button spelling #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix delete button spelling #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/Rifm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const useRifm = (props: Args): RenderProps => {
: props.format(props.value);

// state of delete button see comments below about inputType support
const isDeleleteButtonDownRef = React.useRef(false);
const isDeleteButtonDownRef = React.useRef(false);

const onChange = (
evt: SyntheticInputEvent<HTMLInputElement | HTMLTextAreaElement>
Expand All @@ -57,7 +57,7 @@ export const useRifm = (props: Args): RenderProps => {
eventValue, // eventValue
evt.target, // input
eventValue.length > userValue.length, // isSizeIncreaseOperation
isDeleleteButtonDownRef.current, // isDeleleteButtonDown
isDeleteButtonDownRef.current, // isDeleteButtonDown
userValue === props.format(eventValue), // isNoOperation
];

Expand Down Expand Up @@ -90,15 +90,15 @@ export const useRifm = (props: Args): RenderProps => {
eventValue,
input,
isSizeIncreaseOperation,
isDeleleteButtonDown,
isDeleteButtonDown,
// No operation means that value itself hasn't been changed, BTW cursor, selection etc can be changed
isNoOperation,
] = valueRef.current;
valueRef.current = null;

// this usually occurs on deleting special symbols like ' here 123'123.00
// in case of isDeleleteButtonDown cursor should move differently vs backspace
const deleteWasNoOp = isDeleleteButtonDown && isNoOperation;
// in case of isDeleteButtonDown cursor should move differently vs backspace
const deleteWasNoOp = isDeleteButtonDown && isNoOperation;

const valueAfterSelectionStart = eventValue.slice(input.selectionStart);

Expand Down Expand Up @@ -201,7 +201,7 @@ export const useRifm = (props: Args): RenderProps => {
// it becomes "56-|12-43" with this code, and "56|-12-43" without
if (
props.mask != null &&
(isSizeIncreaseOperation || (isDeleleteButtonDown && !deleteWasNoOp))
(isSizeIncreaseOperation || (isDeleteButtonDown && !deleteWasNoOp))
) {
while (formattedValue[start] && clean(formattedValue[start]) === '') {
start += 1;
Expand All @@ -222,13 +222,13 @@ export const useRifm = (props: Args): RenderProps => {
// firefox track https://bugzilla.mozilla.org/show_bug.cgi?id=1447239
const handleKeyDown = (evt: KeyboardEvent) => {
if (evt.code === 'Delete') {
isDeleleteButtonDownRef.current = true;
isDeleteButtonDownRef.current = true;
}
};

const handleKeyUp = (evt: KeyboardEvent) => {
if (evt.code === 'Delete') {
isDeleleteButtonDownRef.current = false;
isDeleteButtonDownRef.current = false;
}
};

Expand Down