-
Notifications
You must be signed in to change notification settings - Fork 151
feat: allow to pass in relative paths for input files and add assets file #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I can confirm this works, probably the easiest wat to fix this as you need authentication for the download, authentication could be something for down the road. Edit: |
|
@Joshi234 I didn't really understand what you meant, could you rephrase ? |
|
I believe the only observation he had is that the "plugins" folder where the user's plugin is being copied to should be named mods instead for it to work with the hytale jar. It doesn't have anything to do with the PR tho. |
Yeah that and the server jar needs to be set as dependency in the gradle so you can actually write plugins in build.gradle.kts While thoes fixed doen't relate directly to your pr, it would be nice if you could commit them to make this template usable with this pr |
Adjusted the paths in build.gradle.kts to reference the correct locations for HytaleServer.jar and Assets.zip. Updated README to reflect changes in the server's mods folder instead of plugins folder for clarity.
|
I updated the PR with the renaming to |
| // Hytale API (provided by server) | ||
| compileOnly(files("libs/hytale-server.jar")) | ||
| compileOnly(files("./HytaleServer.jar")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected to have ./HytaleServer.jar here while in other places it is at ./libs/HytaleServer.jar ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that in the build.gradle.kts file, there is the following path: "./libs/HytaleServer.jar".

Issue
The
gradlew runServerdoesn't pass in theAssets.zipfile as a parameter, which causes the server to crash.Solution
I added a property in the build.gradle.kts to allow the user to pass in the Assets.zip location so it's used.
Bonus
I also made the two fields be able to accept either URLs, relative, or absolute paths.