Release 0.4.4 #900
Release 0.4.4 #900
Conversation
I knew I shouldn't be doing this manually but it took me a while to figure out what I had to do. I eventually followed the guide for OpenStack Horizon [1]. Add a tox target to avoid this confusion in the future. [1] https://docs.openstack.org/horizon/latest/contributor/topics/translation.html Signed-off-by: Stephen Finucane <stephen@that.guru>
Signed-off-by: Stephen Finucane <stephen@that.guru> This is mostly a no-op though there is one new, thankfully simple translation added and two removed. Old, commented out translations are removed. Signed-off-by: Stephen Finucane <stephen@that.guru>
Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
force-pushed
the
rtfd/release-0.4.4
branch
from
74f57d5
to
f8cc184
Compare
|
@agjohnson is the main point person on the theme. |
| * Fix definition lists looking different with Sphinx 2.0+ | ||
| * Add compatibility with Sphinx 3.x |
There was a problem hiding this comment.
Where was Sphinx 3.x compatibility added?
There was a problem hiding this comment.
3.0.0 was released a year later. That was for Sphinx 2.x compatibility:
sphinx-doc/sphinx#6088
There was a problem hiding this comment.
Sphinx 2.x compatibility is still ongoing:
https://github.com/readthedocs/sphinx_rtd_theme/projects/1
There was a problem hiding this comment.
"Improve compatibility with Sphinx 2.x" is more appropriate
stephenfin
force-pushed
the
rtfd/release-0.4.4
branch
from
f8cc184
to
689e0cf
Compare
|
I wonder if I should roll in dropping support for Python 2.7 and 3.4 here? I'm thinking it would be better get this out the door and cut a 1.0.0 release that does that at a later date, but I'm willing to be overruled 😄 |
|
Okay, it seems this is clearly not ready so it's probably best I close it. Feel free to cherry-pick any of the commits here that might be useful. |
|
Why was this abandoned? |
Do the necessary work to release 0.4.4 and get things working with Sphinx 3.x. After this is merged, I think someone will just need to to tag the relevant commit (
HEAD~) and push the release to PyPI.@ericholscher I assume this falls on you to do? /o\ Let me know if there's anything else I can do to help.
EDIT It might look like there's more going on here than is necessary, but I've broken things up with commits, as seen here.