Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated use of script_files #728

Merged
merged 5 commits into from
Apr 3, 2019
Merged

Conversation

Blendify
Copy link
Member

@Blendify Blendify commented Feb 25, 2019

@ericholscher
Copy link
Member

Is this backwards compat? I believe it should be, but we should make sure to test it on Sphinx 1.8.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good assuming it's backwards compatible. 👍

@Blendify
Copy link
Member Author

Blendify commented Apr 3, 2019

Yes it is backwards compatible.

@Blendify Blendify merged commit a49a812 into master Apr 3, 2019
@Blendify Blendify deleted the Blendify/script_files branch April 3, 2019 14:42
@Ben2022
Copy link

Ben2022 commented Sep 24, 2019

Hi. Could you make a release, please? This issue is blocking us on several projects. Thanks.

@return42 return42 mentioned this pull request Oct 9, 2019
JulianGro added a commit to JulianGro/vircadia-docs-sphinx that referenced this pull request Jan 29, 2021
JulianGro added a commit to JulianGro/vircadia-docs-sphinx that referenced this pull request Feb 2, 2021
jtniehof added a commit to jtniehof/dbprocessing that referenced this pull request Nov 18, 2021
 * Handling of javascript mods for the html changed, wasn't going to
   work in 3.0. Basically copied fix from
   readthedocs/sphinx_rtd_theme#728
 * This was used for the "hide prompts" feature in example code.
   New version still works in 1.6, but no longer in 1.5 or earlier.
   Docs still render fine, just don't have the "hide" button, so this
   is okay.
dnadeau-lanl pushed a commit to spacepy/dbprocessing that referenced this pull request Nov 22, 2021
 * Handling of javascript mods for the html changed, wasn't going to
   work in 3.0. Basically copied fix from
   readthedocs/sphinx_rtd_theme#728
 * This was used for the "hide prompts" feature in example code.
   New version still works in 1.6, but no longer in 1.5 or earlier.
   Docs still render fine, just don't have the "hide" button, so this
   is okay.
9bow added a commit to PyTorchKorea/pytorch_sphinx_theme that referenced this pull request Jun 30, 2022
9bow added a commit to PyTorchKorea/pytorch_sphinx_theme that referenced this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants