-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project to use Ubuntu 22.04 LTS #9010
Conversation
This PR has to be merged after April 21, when Ubuntu 22.04 is released and it will be available on AWS as well. |
23ebc0e
to
6befcb4
Compare
Hrm, it seems that tests are not running because it can install django-allauth since we are using an old version. We should upgrade it (see #9122) before upgrading Ubuntu/Python. There are other benefits mentioned in the issue as well. However, I didn't hit this issue when building the AMI images for production with packer. It seems it's more related to tox's default setuptools than with another thing. |
Ubuntu 22.04 LTS is not yet released, but it's already available to use. We can start allowing testing this image internally before upgrading production servers. Also note that the default Python version was upgraded from 3.8 to 3.10.
f4e494f
to
9b7d39b
Compare
9b7d39b
to
8fe4bea
Compare
@ericholscher @agjohnson @stsewd we should be ready to merge this PR, test it for a week and use the new Ubuntu 22.04 LTS base on next deploy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks simple enough. I'm less worried about it locally as running in production, but overall we don't depend on system-level packages for much beyond Python.
@@ -6,7 +6,7 @@ orbs: | |||
jobs: | |||
tests: | |||
docker: | |||
- image: 'cimg/python:3.8' | |||
- image: 'cimg/python:3.10' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting. We'll finally be on a mostly up to date version of Python :)
RUN sh -c 'echo "deb http://apt.postgresql.org/pub/repos/apt $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list' | ||
RUN curl -s https://www.postgresql.org/media/keys/ACCC4CF8.asc | apt-key add - | ||
RUN apt-get -y update | ||
RUN apt-get -y install postgresql-client-12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ deleting hacky code.
Ubuntu 22.04 LTS is not yet released, but it's already available to use. We can
start allowing testing this image internally before upgrading production
servers.
Also, note that the default Python version was upgraded from 3.8 to 3.10.
Related to #9009