Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap setuptools even if installed packages are ignored #8777

Merged
merged 3 commits into from
Dec 21, 2021
Merged

Cap setuptools even if installed packages are ignored #8777

merged 3 commits into from
Dec 21, 2021

Conversation

astrojuanlu
Copy link
Contributor

Continuation of #8711, see discussion at #8775.

@astrojuanlu astrojuanlu requested a review from a team as a code owner December 21, 2021 01:01
@astrojuanlu
Copy link
Contributor Author

The checks failure is fixed by #8774.

The fact that no tests failed makes me think that this code path is not being tested at all? I will try to add one.

@astrojuanlu
Copy link
Contributor Author

Tests passing 👍

humitos
humitos approved these changes Dec 21, 2021
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks Juanlu for taking care of this!

I'd like to deprecate "use system package" eventually, tho. 😄

@astrojuanlu
Copy link
Contributor Author

I'd like to deprecate "use system package" eventually, tho. 😄

Me too :)

@astrojuanlu astrojuanlu merged commit b958bb8 into master Dec 21, 2021
@astrojuanlu astrojuanlu deleted the always-cap-setuptools branch December 21, 2021 11:23
ericholscher pushed a commit that referenced this pull request Dec 21, 2021
@astrojuanlu @ericholscher
Merge pull request #8777 from readthedocs/always-cap-setuptools
e61f3be 
Cap setuptools even if installed packages are ignored
ericholscher pushed a commit that referenced this pull request Dec 21, 2021
@astrojuanlu @ericholscher
Merge pull request #8777 from readthedocs/always-cap-setuptools
2c0bcf9 
Cap setuptools even if installed packages are ignored
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Dec 21, 2021
@ericholscher ericholscher mentioned this pull request Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrojuanlu @humitos @ericholscher