-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change some info logging to debug to clean up build output #5233
Conversation
This should make it easier to follow along with builds. If you need the additional logging, you can always do `tail -F logs/debug.log`.
else: | ||
resp = api_v2.command.post(data) | ||
log.info('Post response via JSON encoded data: %s', resp) | ||
log.debug('Post response via JSON encoded data: %s', resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the most important, as they are currently spamming our build logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added because we were experimenting some issues while posting big outputs. That is working fine now and I think the logs are not more necessary. 👍 on .debug
it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good!
If you need the additional logging, you can always do
tail -F logs/debug.log
.
I think this is possible on local development, but it does not work in production, right? I'm assuming that the log level we have configured is INFO.
else: | ||
resp = api_v2.command.post(data) | ||
log.info('Post response via JSON encoded data: %s', resp) | ||
log.debug('Post response via JSON encoded data: %s', resp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added because we were experimenting some issues while posting big outputs. That is working fine now and I think the logs are not more necessary. 👍 on .debug
it.
Yep. We could write a debug log in prod perhaps, and only keep it for 1 day, since it's quite spammy. It's often times useful to have debug logging in prod even tho. |
This should make it easier to follow along with builds. If you need the additional logging, you can always do
tail -F logs/debug.log
.