Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync all services even if one social accoun fails #5171

Merged
merged 5 commits into from
Jan 29, 2019

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 25, 2019

Fix #4076

We are losing the specific error (failed while syncing repos or organizations), but we have the name of all services that need to be fixed.

This is how it looks like with one and two accounts

screenshot_2019-01-24 import a remote repository read the docs 1
screenshot_2019-01-24 import a remote repository read the docs

@stsewd stsewd added Needed: tests Tests are required PR: work in progress Pull request is not ready for full review labels Jan 25, 2019
@stsewd stsewd removed Needed: tests Tests are required PR: work in progress Pull request is not ready for full review labels Jan 29, 2019
@stsewd stsewd requested a review from a team January 29, 2019 03:43
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my side. 👍

@ericholscher ericholscher merged commit 86043cc into readthedocs:master Jan 29, 2019
@stsewd stsewd deleted the sync-all-services branch January 29, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If one social account fails on sync the rest are not executed
2 participants