Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default_branch value from Version.slug to Version.identifier #5034

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Change default_branch value from Version.slug to Version.identifier #5034

merged 1 commit into from
Dec 26, 2018

Conversation

dojutsu-user
Copy link
Member

Fixes #5032

@humitos humitos requested a review from a team December 24, 2018 19:45
humitos
humitos approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks!

I tested this locally with my example of "project not building because of this issue" and it did work.

stsewd
stsewd approved these changes Dec 26, 2018
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a grep on the project, I can confirm that we use identifier when accessing to default_branch

@ericholscher ericholscher merged commit f7926c4 into readthedocs:master Dec 26, 2018
@ericholscher
Copy link
Member

Makes sense. The identifier is the VCS concept, and slugs might be weird because we change them :)

@dojutsu-user dojutsu-user deleted the change-slug-to-identifier branch December 29, 2018 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stsewd stsewd stsewd approved these changes

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dojutsu-user @ericholscher @humitos @stsewd