Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace git status and git submodules status for gitpython #5002

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Replace git status and git submodules status for gitpython #5002

merged 1 commit into from
Dec 18, 2018

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Dec 14, 2018

Closes #3839

humitos
humitos approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Do we already have some tests for this?

@stsewd
Copy link
Member Author

stsewd commented Dec 17, 2018 •
edited
Loading

Yes we have, diff coverage shows that too.

codecov/patch — 100% of diff hit (target 76.74%)

@humitos humitos merged commit dfbe6df into readthedocs:master Dec 18, 2018
@stsewd stsewd deleted the use-git-python branch December 18, 2018 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos