Add 'Branding' under the 'Business Info' section and 'Guidelines' on 'Design Docs' #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4830 +/- ##
==========================================
+ Coverage 76.2% 76.21% +0.01%
==========================================
Files 158 158
Lines 10022 10019 -3
Branches 1265 1265
==========================================
- Hits 7637 7636 -1
+ Misses 2041 2039 -2
Partials 344 344
|
|
This looks good. The ticket mentions adding a reference in the documentation as well, so I think we should add that in this PR as well 👍 |
dojutsu-user
changed the title
|
@ericholscher done. |
|
Great, I've pushed a small copy edit, and merging it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final Result
Related Issue: #3594