Do not access database from builds to check ad-free #4387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the previous fix in #4329 which resulted in builders trying to access the database (
project.gold_owners.exists
makes a query). The builders don't have access to the database so this was a problem. Instead, this returns ashow_advertising
field on the API which checks bothproject.ad_free
andproject.gold_owners.exists
.The end result is that ad-free projects -- whether marked ad-free at the database level or because they have a Gold sponsor -- should not show the ad-block nag.
Fixes #4218