Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make get_version usable from a specified path #4376

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Make get_version usable from a specified path #4376

merged 2 commits into from
Jul 20, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 16, 2018

Allow to use the get_version util by passing a path to a standard setup.cfg file instead of guess it as a relative path from current __file__.

@humitos humitos requested a review from a team July 16, 2018 21:07
@ericholscher
Copy link
Member

Seems like this is just moving where the guess setup.cfg logic is. I'm guessing this is meant to be extended somewhere else?

@humitos humitos mentioned this pull request Jul 18, 2018
Closed
@humitos
Copy link
Member Author

humitos commented Jul 18, 2018

@ericholscher yes, the idea is to share this get_version code with the corporate site: https://github.com/rtfd/readthedocs-corporate/pull/369

In the corporate repo we pass a different setup.cfg path.

@agjohnson agjohnson merged commit 9a5f019 into master Jul 20, 2018
@agjohnson agjohnson deleted the humitos/module/version branch July 20, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humitos @ericholscher @agjohnson