Fix deprecations in management commands #4321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Jul 3, 2018
humitos
reviewed
Jul 6, 2018
| @@ -26,22 +26,30 @@ class Command(BaseCommand): | |||
| """Management command for rebuilding documentation on projects""" | |||
|
|
|||
| help = __doc__ | |||
| option_list = BaseCommand.option_list + ( | |||
There was a problem hiding this comment.
It seems that we lose the positional arguments:
manage.py update_repos mkdocs
doesn't work anymore.
This command is used when import_from_live is called.
From the example at https://docs.djangoproject.com/en/1.9/howto/custom-management-commands/#custom-commands-options we need some extra lines to allow that.
I had to add this to make it work.
parser.add_argument('slugs', nargs='+', type=str)
Probably similar work is needed in the rest of the commands.
cc @stsewd
There was a problem hiding this comment.
I'll see if I can fix this today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding arguments via
option_listwas deprecated in django 1.8 and it is removed en django1.10https://docs.djangoproject.com/en/1.9/howto/custom-management-commands/#django.core.management.BaseCommand.option_list
Raised in #4319 (comment)