Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute order call #3930

Merged
merged 1 commit into from
Apr 10, 2018
Merged

Fix attribute order call #3930

merged 1 commit into from
Apr 10, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 10, 2018

Keep compatibility (order) with the other services

Related https://github.com/readthedocs/readthedocs-corporate/issues/297

@humitos
Fix attribute order call
6cc40e6 
Keep compatibility (order) with the other services
agjohnson
agjohnson approved these changes Apr 10, 2018
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised our linting didn't pick up on this due to mismatch argument lists. Oh well. LGTM

@humitos humitos merged commit 64def2d into master Apr 10, 2018
@humitos humitos deleted the humitos/integrations/fixes branch April 10, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson