-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes internal reference #3695
Fixes internal reference #3695
Conversation
4fa51ee
to
1b56f9d
Compare
1b56f9d
to
6ce5a18
Compare
The reference looks like it should work just fine, and appears to do so in testing this in our docs. Is there a specific issue this is addressing? |
I can also see that this works fine on the docs. @bansalnitish this references are created implicitly from the title http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#implicit-hyperlink-targets |
@agjohnson @stsewd I changed the reference from implicit to explicit because implicit references are mostly error-prone when we rename sections or try to duplicate them. Using |
@bansalnitish By the way there is a PR in progress #3624 to catch that kind of errors on the docs. |
That is great @stsewd! |
HI @stsewd, any updates on this! |
@bansalnitish Not sure if this PR is really needed since the current ref works just fine. |
Thanks, @stsewd! I am closing this one! |
This PR fixes an internal reference in
abandoned-projects.rst