Versions: allow latest to be a tag #10738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were kind of always expecting latest (machine created) to be a branch (the field is even named
default_branch
!).But we were allowing both branches and tags to be the default version (latest).
readthedocs.org/readthedocs/projects/forms.py
Lines 272 to 279 in 53e21bb
The identifier of a tag is a commit, but users reference latest from the name of the tag, so I'm storing the name instead of the commit in that case. We could do the same for stable to solve #10715.
Closes #10735