Downloadable artifacts: make PDF and ePub opt-in by default #10115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly created projects will have PDF and ePub disabled by default. This matches the default value of `formats` in the YAML file v2. Building PDF and ePub is not a trivial task and many projects start failing because of this or, if succeeding, they are just building pretty low quality PDF and ePub files --which is a waste of resources. This commit disables this by default for new projects, keeping the old projects working as they are currently.
ericholscher
approved these changes
Mar 6, 2023
There was a problem hiding this comment.
I'm 👍 on this. We definitely want folks opting into this if they want it. I wish there was an easy way to turn it off for projects that don't care, but stopping it defaulting on is step 1 :)
I'm a little surprised tests didn't break with this change, which shows that our build infra definitely is our least tested area, I think 🤔
Yeah. Testing build workflow is hard. I've done lot of it when migrating our code to Celery handlers. However, it's super fragile and hard to follow/read due to the amount of mocks we are using 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly created projects will have PDF and ePub disabled by default. This matches the default value of
formatsin the YAML file v2.Building PDF and ePub is not a trivial task and many projects start failing because of this or, if succeeding, they are just building pretty low quality PDF and ePub files --which is a waste of resources.
This commit disables this by default for new projects, keeping the old projects working as they are currently.
Closes #8359