Merge pull request #4489 from rtfd/davidfischer/all-static-collectstatic

All static media is run through "collectstatic"

.gitignore

@@ -32,6 +32,7 @@ media/json
 media/man
 media/pdf
 media/static
+/static
 node_modules
 package-lock.json
 readthedocs/rtd_tests/builds

media/font/fontawesome_webfont.woff2

@@ -0,0 +1 @@
+../../readthedocs/core/static/core/font/fontawesome-webfont.woff2

media/fonts

@@ -1 +1 @@
-../readthedocs/core/static/core/font/
+../readthedocs/core/static/core/font

readthedocs/settings/base.py

@@ -167,7 +167,7 @@ def USE_PROMOS(self):  # noqa
     PRODUCTION_MEDIA_ARTIFACTS = os.path.join(PRODUCTION_ROOT, 'media')
 
     # Assets and media
-    STATIC_ROOT = os.path.join(SITE_ROOT, 'media/static/')
+    STATIC_ROOT = os.path.join(SITE_ROOT, 'static')
     STATIC_URL = '/static/'
     MEDIA_ROOT = os.path.join(SITE_ROOT, 'media/')
     MEDIA_URL = '/media/'

readthedocs/templates/base.html

@@ -10,7 +10,7 @@
   <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
   {% block extra_metas %}{% endblock extra_metas %}
 
-  <link rel="icon" type="image/png" href="{{ MEDIA_URL }}images/favicon.png">
+  <link rel="icon" type="image/png" href="{% static 'images/favicon.png' %}">
 
   <!-- title -->
   <title>{% block title %}{% endblock %}{% block head_title %}{% endblock %} | {% block branding %}Read the Docs {% endblock %}</title>
@@ -47,7 +47,7 @@
   <!-- End Google Analytics -->
 
   <!-- css -->
-  <link rel="stylesheet" href="{{ MEDIA_URL }}css/core.css">
+  <link rel="stylesheet" href="{% static 'css/core.css' %}">
   {% block extra_links %}{% endblock %}
 
   <!-- jquery -->
@@ -58,7 +58,7 @@
     require('jquery');
   </script>
 
-  <script src="{{ MEDIA_URL }}javascript/base.js"></script>
+  <script src="{% static 'javascript/base.js' %}"></script>
   <script src="{% static 'core/js/site.js' %}"></script>
   <script>
     var site = require('core/site');

readthedocs/templates/builds/build_list.html

@@ -1,6 +1,7 @@
 {% extends "projects/base_project.html" %}
 
 {% load i18n %}
+{% load static %}
 
 {% load pagination_tags %}
 {% load privacy_tags %}
@@ -74,7 +75,7 @@ <h1>{% trans "Recent Builds" %}</h1>
 
 {% block extra_scripts %}
 {{ block.super }}
-  <script type="text/javascript" src="{{ MEDIA_URL }}javascript/build_updater.js"></script>
+  <script type="text/javascript" src="{% static 'javascript/build_updater.js' %}"></script>
 
   <script type="text/javascript">
     $(function() {

readthedocs/urls.py

@@ -1,14 +1,15 @@
 # pylint: disable=missing-docstring
 from __future__ import absolute_import
 
+import os
 from functools import reduce
 from operator import add
 
 from django.conf.urls import url, include
 from django.contrib import admin
 from django.conf import settings
 from django.conf.urls.static import static
-from django.views.generic.base import TemplateView
+from django.views.generic.base import TemplateView, RedirectView
 from tastypie.api import Api
 
 from readthedocs.api.base import (ProjectResource, UserResource,
@@ -85,13 +86,20 @@
         TemplateView.as_view(template_name='dnt-policy.txt', content_type='text/plain')),
 ]
 
-debug_urls = add(
-    [
-        url('style-catalog/$',
-            TemplateView.as_view(template_name='style_catalog.html')),
-    ],
-    static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)
-)
+debug_urls = []
+for build_format in ('epub', 'htmlzip', 'json', 'pdf'):
+    debug_urls += static(
+        settings.MEDIA_URL + build_format,
+        document_root=os.path.join(settings.MEDIA_ROOT, build_format),
+    )
+debug_urls += [
+    url('style-catalog/$',
+        TemplateView.as_view(template_name='style_catalog.html')),
+
+    # This must come last after the build output files
+    url(r'^media/(?P<remainder>.+)$',
+        RedirectView.as_view(url=settings.STATIC_URL + '%(remainder)s'), name='media-redirect'),
+]
 
 # Export URLs
 groups = [basic_urls, rtd_urls, project_urls, api_urls, core_urls, i18n_urls, deprecated_urls]