Call preventDefault() in "Esc" event listener #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, sorry for the late review, I just hit this, but this doesn't fix the issue, I think we may need to narrow down the listener (currently set to the whole document), or may be another way to achieve this? |
stsewd
added a commit
that referenced
this pull request
Mar 7, 2022
Two things: - The scope of the event needs to be narrowed down (from document to just the modal). - We need to call stopPropagation so the event isn't triggered for the document object. Closes #103
|
This kind of works #104 |
stsewd
added a commit
that referenced
this pull request
Apr 5, 2022
Two things: - The scope of the event needs to be narrowed down (from document to just the modal). - We need to call stopPropagation so the event isn't triggered for the document object. Closes #103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested, but it should prevent the keypress to be propagated after closing the popup, which is not desired, e.g. in sphinx-doc/sphinx#9337.