Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10.0b3 and upgrade to Miniconda3-4.9.2 #174

Merged
merged 14 commits into from
Jul 22, 2021

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 8, 2021

Install Python 3.10.0b3 and upgrade to Miniconda3-py38-4.9.2.

NOTE that Miniconda3-py39_4.10.1 is not available for Linux x86_64 so I had to
pick the previous one

Upgrading Miniconda2 to Miniconda3 changes the default behavior when the user
doesn't specify the python version (build.python.version). The environment
will be created with Python3 by default now instead of Python2.
See #86

I don't think this will affect too many users since this PR is going to be
merged into release/7.x branch (testing image) that only a few users are
currently using.

Closes #152
Closes #173
Closes #171
Related #147
Related #158
Requires readthedocs/readthedocs.org#8328
Requires a git tag 7.0.8 on this repository once this PR is merged into releases/7.x
Requires a PR in -ops upgrading the hash for testing image once it's built on DockerHub

Install Python 3.10.0b3 and upgrade to Miniconda3-py38-4.9.2.

> NOTE that Miniconda3-py39_4.10.1 is not available for Linux x86_64 so I had to
> pick the previous one

Upgrading Miniconda2 to Miniconda3 changes the default behavior when the user
doesn't specify the python version (`build.python.version`). The environment
will be created with Python3 by default now instead of Python2.
See #86

I don't think this will affect too many users since this PR is going to be
merged into `release/7.x` branch (`testing` image) that only a few users are
currently using.
@humitos humitos requested a review from a team July 8, 2021 08:29
@humitos
Copy link
Member Author

humitos commented Jul 8, 2021

@agjohnson @ericholscher we may want to include the upgrade for Rust to 1.53 (https://www.rust-lang.org/es) in this PR as well since it was already requested by a user in #170 --what do you think?

@ericholscher
Copy link
Member

This looks mostly safe. I think we should move forward with it after feedback in #173.

@agjohnson @ericholscher we may want to include the upgrade for Rust to 1.53 (https://www.rust-lang.org/es) in this PR as well since it was already requested by a user in #170 --what do you think?

I'd like to handle these upgrades one at a time if possible. I think doing conda & python 3.10 is probably safe, since nobody is using 3.10 yet. So the primary breaking change here is conda, which will almost certainly break something, but not too many conda users using testing.

Dockerfile Outdated Show resolved Hide resolved
@humitos
Copy link
Member Author

humitos commented Jul 20, 2021

Once tests pass, I will merge this PR and tag it as 7.0.8 so it builds on Docker Hub as well. After that, we will do some QA with @astrojuanlu on some projects using Conda and Python3.10

@astrojuanlu
Copy link
Contributor

Once tests pass

Sorry, where are you seeing the tests? There are no checks in this PR

@humitos humitos force-pushed the humitos/py310b-miniconda3-4.9.2 branch 16 times, most recently from 25d5581 to c5be817 Compare July 20, 2021 11:43
@humitos
Copy link
Member Author

humitos commented Jul 20, 2021

Sorry, where are you seeing the tests? There are no checks in this PR

Yeah, I'm dealing with it. They were running in TravisCI. I'm migrating them to CircleCI and having multiple colorful issues 🙃 --but I'm close.

`nodejs` and `npm` are not compatible with `libssl-dev` and `libxmlsec1-dev`
which are required to build Python versions with pyenv.

We first build the Python versions and then install the incompatible packages.
@humitos humitos force-pushed the humitos/py310b-miniconda3-4.9.2 branch from 16d9281 to c6f7568 Compare July 21, 2021 09:46
@humitos humitos force-pushed the humitos/py310b-miniconda3-4.9.2 branch from 69e706b to 0ea7d2d Compare July 21, 2021 13:58
@humitos humitos merged commit 852eb83 into releases/7.x Jul 22, 2021
@humitos humitos deleted the humitos/py310b-miniconda3-4.9.2 branch July 22, 2021 10:11
@humitos
Copy link
Member Author

humitos commented Jul 22, 2021

stsewd pushed a commit to readthedocs/readthedocs.org that referenced this pull request Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants