-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.10.0b3 and upgrade to Miniconda3-4.9.2 #174
Conversation
Install Python 3.10.0b3 and upgrade to Miniconda3-py38-4.9.2. > NOTE that Miniconda3-py39_4.10.1 is not available for Linux x86_64 so I had to > pick the previous one Upgrading Miniconda2 to Miniconda3 changes the default behavior when the user doesn't specify the python version (`build.python.version`). The environment will be created with Python3 by default now instead of Python2. See #86 I don't think this will affect too many users since this PR is going to be merged into `release/7.x` branch (`testing` image) that only a few users are currently using.
@agjohnson @ericholscher we may want to include the upgrade for Rust to 1.53 (https://www.rust-lang.org/es) in this PR as well since it was already requested by a user in #170 --what do you think? |
This looks mostly safe. I think we should move forward with it after feedback in #173.
I'd like to handle these upgrades one at a time if possible. I think doing conda & python 3.10 is probably safe, since nobody is using 3.10 yet. So the primary breaking change here is conda, which will almost certainly break something, but not too many conda users using |
Once tests pass, I will merge this PR and tag it as |
Sorry, where are you seeing the tests? There are no checks in this PR |
25d5581
to
c5be817
Compare
Yeah, I'm dealing with it. They were running in TravisCI. I'm migrating them to CircleCI and having multiple colorful issues 🙃 --but I'm close. |
cff719a
to
435a176
Compare
`nodejs` and `npm` are not compatible with `libssl-dev` and `libxmlsec1-dev` which are required to build Python versions with pyenv. We first build the Python versions and then install the incompatible packages.
16d9281
to
c6f7568
Compare
69e706b
to
0ea7d2d
Compare
Image 7.0.8 is building in docker hub at https://hub.docker.com/repository/registry-1.docker.io/readthedocs/build/builds/90e9c07e-1986-4a18-abb5-0218b1def3cb |
Install Python 3.10.0b3 and upgrade to Miniconda3-py38-4.9.2.
Upgrading Miniconda2 to Miniconda3 changes the default behavior when the user
doesn't specify the python version (
build.python.version
). The environmentwill be created with Python3 by default now instead of Python2.
See #86
I don't think this will affect too many users since this PR is going to be
merged into
release/7.x
branch (testing
image) that only a few users arecurrently using.
Closes #152
Closes #173
Closes #171
Related #147
Related #158
Requires readthedocs/readthedocs.org#8328
Requires a git tag
7.0.8
on this repository once this PR is merged intoreleases/7.x
Requires a PR in -ops upgrading the hash for
testing
image once it's built on DockerHub