Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 8.0 #137

Merged
merged 9 commits into from
Sep 24, 2020
Merged

New version 8.0 #137

merged 9 commits into from
Sep 24, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 27, 2020

  • updates base image to Ubuntu 20.04 LTS
  • adds Python 3.9.0rc1 (adding it now to avoid having to release 9.0 soon)
  • updates readme to mention newer images (stable, latest, testing)
  • do not install numpy, pandas and matplotlib in Python 3.9
    • this will be the first version of Python without these dependencies at "system package" level
    • we talked about removing them some time ago because it's not trust-able (not pinned version)
    • users using these package usually install them via conda (or regular pip)

Documentation to deploy this image into the servers once it's merged: https://docs.ops.verbthenouns.com/projects/community-ops/en/latest/deploying-docker-image.html

@humitos humitos added the PR: work in progress Pull request is not ready for full review label Aug 27, 2020
@humitos humitos removed the PR: work in progress Pull request is not ready for full review label Sep 1, 2020
@humitos
Copy link
Member Author

humitos commented Sep 3, 2020

Note that we added rust to image 7.0. We may need to rebase this branch with master.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, should definitely build this on top of master. I still don't love our workflow here, but don't have any concrete improvements to suggest.

``testing``
Ubuntu 18.04 supporting Python 2.7, 3.5, 3.6, 3.7, 3.8 and PyPy3.5-7.0.0.
Ubuntu 20.04 supporting Python 2.7, 3.5, 3.6, 3.7, 3.8, 3.9.0rc1 and PyPy3.5-7.0.0.
For internal development **testing** only, not available for public usage yet.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this available as a testing image on RTD? We just don't document it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This image is available via the config file build: image: testing but we don't document it.

@humitos
Copy link
Member Author

humitos commented Sep 21, 2020

I'll build this on top of master and merge after tomorrow's deploy.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Far fewer changes than I was expecting for the upgrade here, that's good news.

Dockerfile Outdated Show resolved Hide resolved
humitos and others added 9 commits September 24, 2020 11:14
Since we are upgrading the Docker image version, it's good to be prepared to
have a newer Python version as well.

We can start testing 3.9.0rc1 and finally upgrade to 3.9.0 stable in a minor fix
docker image release.
It does not exist anymore in 20.04
Co-authored-by: Anthony <aj@ohess.org>
@humitos
Copy link
Member Author

humitos commented Sep 24, 2020

Rebased the branch with master. It should be ready to test more locally and deploy.

@humitos humitos merged commit 6e61b2a into master Sep 24, 2020
@humitos humitos deleted the humitos/new-version-8.0 branch September 24, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants