Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build an aggregation for ad rotations #928

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

davidfischer
Copy link
Collaborator

Testing

  • Perform an ad rotation (even manually) but hitting the API endpoint and making sure to pass rotations=2.
  • Aggregate the data:
    from adserver.utils import update_previous_day_reports
    update_previous_day_reports("2024-10-18")
  • Check the rotations in the admin

@davidfischer davidfischer requested a review from a team as a code owner October 18, 2024 18:14
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough. I really wish the aggregation logic was easier to abstract so we didn't have all of the complex query logic in each one, but so it goes.

@davidfischer davidfischer merged commit 63e33b3 into main Oct 21, 2024
1 check passed
@davidfischer davidfischer deleted the davidfischer/rotation-aggregation branch October 21, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants