Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match notification style with flyout #543

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Match notification style with flyout #543

wants to merge 3 commits into from

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 19, 2025 •
edited
Loading

@ericholscher ericholscher requested review from humitos and a team as code owners February 19, 2025 00:24
@ericholscher
Copy link
Member Author

I wasn't sure if we were currently using inverted at all?

@agjohnson
Copy link
Contributor

I was saying in our meeting that we shouldn't yet match the light theme elements against the flyout. Same with the diff UI. These are dark mode themes and they stand out a great deal on light mode themes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos Awaiting requested review from humitos humitos is a code owner

@agjohnson agjohnson Awaiting requested review from agjohnson agjohnson is a code owner automatically assigned from readthedocs/frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @agjohnson