Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force black text for search input #540

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 18, 2025

Fixes #420

Screenshot 2025-02-18 at 2 14 53 PM
Screenshot 2025-02-18 at 2 15 00 PM

@ericholscher ericholscher requested review from humitos and a team as code owners February 18, 2025 22:14
@ericholscher
Copy link
Member Author

ericholscher commented Feb 18, 2025

This lints fine for me locally 🤷

-> npm run lint

> @readthedocs/addons@0.30.0 lint
> prettier --check .

Checking formatting...
All matched files use Prettier code style!

@ericholscher
Copy link
Member Author

I updated my hooks and got this, but then pre-commit changes it back 🙃

prettier.................................................................Failed
- hook id: prettier
- files were modified by this hook

@agjohnson
Copy link
Contributor

You probably have an old version of prettier installed and pre-commit/circleci are using the later release. npm install should fix discrepancies with linting like this, this solved what was probably the same issue for me.

Co-authored-by: Anthony <aj@ohess.org>
@humitos
Copy link
Member

humitos commented Feb 20, 2025

You should probably do the same work for the "X" shown at the right of the input field. It's currently white as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: Input text is white on white on dark mode
3 participants