Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EthicalAds: Default to fixedfooter for smaller screens #447

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

EthicalAds: Default to fixedfooter for smaller screens #447

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a831f71
Default to fixedfooter for smaller screens
ericholscher Nov 22, 2024
3b7e92e
Small fixes
ericholscher Nov 22, 2024
a4ef3ab
Note it's a hack
ericholscher Nov 22, 2024
0f36172
Dont' edit addons.js
ericholscher Dec 11, 2024
3848033
Add classes and remove old fixedfooter logic
ericholscher Dec 13, 2024
0ec38cf
Merge branch 'main' of github.com:readthedocs/addons into ea-fixedfooter
ericholscher Jan 10, 2025
f6d18e0
Clean up logic
ericholscher Jan 10, 2025
9929bc2
Add note
ericholscher Jan 10, 2025
cd25c99
Add bottom spacing to footer elements as well as content
ericholscher Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Default to fixedfooter for smaller screens 
This is something I've wanted for a little while.
I don't think we're quite ready to ship it,
but I think it makes sense in a lot of cases.

I'm generally becoming more excited about this placement,
especially when the floating one is pretty intrusive.
  • Loading branch information
@ericholscher
ericholscher committed Dec 11, 2024
commit a831f71512eedbdcb8c1ddbaac19a3ca3d9dbbdc
Loading