Fix up failing checks #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agjohnson
commented
Sep 13, 2023
agjohnson
commented
- Build assets missed
- Drop unused tests
- Update package lock
- Don't install NPM 10 at RTD
- Build assets missed - Drop unused tests - Update package lock - Don't install NPM 10 at RTD
|
I gave a quick try to fixing the tests temporarily, but I think web-test-runner is bound to give us less problems here, and supports ES6 modules natively where Jest needs more hand holding. I'd say let's aim for #73 to resolve the tests |
humitos
approved these changes
Sep 14, 2023
| @@ -11,7 +11,7 @@ build: | |||
| - sphinx-build -b html docs/ $READTHEDOCS_OUTPUT/html | |||
|
|
|||
| # Bundle the current version | |||
| - npm install -g npm@latest | |||
| - npm install -g npm@next-9 | |||
There was a problem hiding this comment.
This is an NPM dist tag that can be used (latest is also a dist tag). For instance, you can see the tags for the npm package with:
npm show npm
next-9 should point to the latest in the 9 series.
There was a problem hiding this comment.
Ah, OK. BTW, I'm using nodejs 18.15.0 and npm 9.5.0 locally.
There was a problem hiding this comment.
Aye, same. NPM 10 started requiring Node 18.17+ or something, but also I don't know we need bleeding edge NPM either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.