Fix init pattern bug and clean up base code (#48)

Some fixes @humitos noted post-review --------- Co-authored-by: Manuel Kaufmann <humitos@gmail.com>
readthedocs · Apr 13, 2023 · 9cf1500 · 9cf1500
1 parent 83bb85d
commit 9cf1500
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/dist/readthedocs-client.js b/dist/readthedocs-client.js
diff --git a/src/analytics.js b/src/analytics.js
@@ -86,6 +86,6 @@ export class AnalyticsAddon extends AddonBase {
   }
 
   static isEnabled(config) {
-    return this.config.features && this.config.features.analytics.enabled;
+    return config.features && config.features.analytics.enabled;
   }
 }
diff --git a/src/index.js b/src/index.js
@@ -22,7 +22,7 @@ export function setup() {
         ];
 
         for (const addon of addons) {
-          if (addon.isEnabled) {
+          if (addon.isEnabled(config)) {
             promises.push(
               new Promise((resolve) => {
                 resolve(new addon(config));

diff --git a/src/utils.js b/src/utils.js
@@ -45,7 +45,7 @@ export const domReady = new Promise((resolve) => {
  * and loading.
  */
 export class AddonBase {
-  static isEnabled() {
+  static isEnabled(config) {
     return false;
   }
 }