feat: supporting react 18 #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
requested review from
a team,
ellierossuck,
kellyjosephprice and
rafegoldberg
and removed request for
a team
kellyjosephprice
approved these changes
May 2, 2022
| run: npm i react@${{ matrix.react }} react-dom@${{ matrix.react }} | ||
|
|
||
| # `@testing-library/react@13` dropped support for React 16 and 17 so to ensure that we run | ||
| # fine under React 18 we should upgrade it if we're testing React 18. |
Contributor
There was a problem hiding this comment.
That's annoying, good note though.
Contributor
There was a problem hiding this comment.
Would this be better handled by a postinstall script? That way it works locally too?
Got the idea here: https://stackoverflow.com/a/60603000/659661
Member
Author
There was a problem hiding this comment.
I'm weary of putting it in a postinstall script because those run when you install the package from npm.
Contributor
There was a problem hiding this comment.
Oh, TIL. I should probably learn more about npm...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
🧬 QA & Testing
All React 18 tests should be passing!