feat: supporting react 17 #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
enhancement
erunion
requested review from
a team,
kellyjosephprice,
rafegoldberg and
thenaomiday
and removed request for
a team
erunion
commented
Mar 31, 2022
| expect(changeSelected).toHaveBeenCalledWith('project2'); | ||
|
|
||
| expect(variable.state('showDropdown')).toBe(false); | ||
| expect(container.querySelector('select')).not.toBeInTheDocument(); |
Member
Author
There was a problem hiding this comment.
Was able to replace the showDropdown state check by checking if the dropdown exists in the DOM instead.
kellyjosephprice
approved these changes
Mar 31, 2022
| "peerDependencies": { | ||
| "react": "16.x" | ||
| "react": "16.x || 17.x", | ||
| "react-dom": "16.x || 17.x" |
Member
Author
There was a problem hiding this comment.
Had to add react-dom to this because @testing-library/react@12 has a peerDep of react-dom: * and that was attempting to pull down react@18.
rafegoldberg
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This will incur a breaking release.