feat: allow different prop #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
reviewed
May 22, 2024
index.jsx
Outdated
| } | ||
|
|
||
| getName() { | ||
| return this.props.name || this.props.variable; |
Member
There was a problem hiding this comment.
does this need a third fallback in case name and variable are both missing?
Member
There was a problem hiding this comment.
maybe itll be okay because doing arr[undefined] just returns undefined.
Contributor
Author
There was a problem hiding this comment.
It ought to be a runtime or compile time error? Should I throw like a Props missing error?
erunion
approved these changes
May 22, 2024
Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Allows the use of the prop: "name".
Since this is going to be a "public" component soon, we thought a less repetitive prop would be appropraite?
🧬 QA & Testing