Skip to content

fix: dont match linebreaks #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kellyjosephprice merged 2 commits into from
Jul 20, 2023
Merged

fix: dont match linebreaks #214

kellyjosephprice merged 2 commits into from
Jul 20, 2023

Conversation

@kellyjosephprice
Copy link
Contributor

@kellyjosephprice kellyjosephprice commented Jul 20, 2023

🚥 Resolves CX-138

🧰 Changes

This PR prevents matching against line breaks.

🧬 QA & Testing

Consider the following markdown:

```
some bash << readline
not a var >> log.txt
```

@kellyjosephprice kellyjosephprice marked this pull request as ready for review July 20, 2023 18:11
erunion
erunion approved these changes Jul 20, 2023
View reviewed changes
@kellyjosephprice @erunion
Update __tests__/index.test.jsx
38672ae 
Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com>
@kellyjosephprice kellyjosephprice merged commit f3ce496 into main Jul 20, 2023
@kellyjosephprice kellyjosephprice deleted the fix/dont-match-linebreaks branch July 20, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erunion erunion erunion approved these changes

@domharrington domharrington Awaiting requested review from domharrington

@rafegoldberg rafegoldberg Awaiting requested review from rafegoldberg

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kellyjosephprice @erunion