Fix viewport-width decorations drawn under the notch in landscape - #870
Draft
mickael-menu wants to merge 1 commit into
Draft
Fix viewport-width decorations drawn under the notch in landscape#870mickael-menu wants to merge 1 commit into
mickael-menu wants to merge 1 commit into
Conversation
Fixes #660. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stevenzeck
reviewed
Aug 14, 2026
Comment on lines
+129
to
+132
| sendSafeAreaInsetsTask = Task { [previousTask = sendSafeAreaInsetsTask] in | ||
| await previousTask?.value | ||
| _ = await evaluateScript(script) | ||
| } |
Contributor
There was a problem hiding this comment.
Should [weak self] be used in case the view is no longer there while the task is still executing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #660.
In reflowable EPUBs the web view spans the full screen width, so decorations using the
viewportorpagewidth were positioned from the physical screen edge, ending up under the notch or home indicator in landscape on notched iPhones.The reflowable spread view now forwards the horizontal safe-area insets to the JavaScript layer through a new
readium.setSafeAreaInsetsAPI, and the decorator insetsviewport- andpage-width decorations accordingly — applying page insets only to the columns touching the viewport edges in multi-column spreads (RTL-aware). Decorations relayout automatically when the insets change on rotation, and inset updates are serialized so rapid rotation events can't apply stale values out of order. Vertical writing modes are intentionally unaffected (their full-span axis is already inset natively).Needs on-device verification on a notched iPhone in landscape:
.viewport-width decorations in paginated and scroll mode,.page-width decorations in two-column layout, and a regression check on standardwraphighlights.🤖 Generated with Claude Code